FH-1031: Add ISO download URLs to README #31
Conversation
WalkthroughUpdated README.md: added an ISO download table for x86_64 and aarch64, replaced a plain note with a Markdown admonition describing two installer-image differences (Flakes enabled via Determinate Nix; NetworkManager used), and expanded the installed-tools section to document Determinate Nix/determinate-nixd and the fh CLI with usage examples. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lucperkins
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
38-39: Pluralize and tighten the NOTE; use upstream tool name casing.Clarifies scope (both images), avoids “identical” ambiguity, and uses “wpa_supplicant”.
Apply this diff:
-> [!NOTE] -> This NixOS installer image is identical to NixOS's ISOs, but with flakes enabled by default via Determinate Nix and NetworkManager enabled instead of bare WPA Supplicant. +> [!NOTE] +> These installer images are functionally identical to the upstream NixOS ISOs, with two differences: +> - flakes are enabled by default via Determinate Nix +> - NetworkManager is enabled instead of wpa_supplicant
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
15-15: Bare URL used
(MD034, no-bare-urls)
16-16: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build (UbuntuLatest32Cores128G, x86_64-linux)
- GitHub Check: build (UbuntuLatest32Cores128GArm, aarch64-linux)
🔇 Additional comments (1)
README.md (1)
11-17: Replace bare URLs with Markdown links (fixes MD034) — add reference-style defs and verify redirects.Quick check: both URLs returned HTTP 307 (temporary redirect) — follow redirects (curl -L) or use the final destination URLs in the refs before merging.
Apply this diff:
-You can download the ISOs at these addresses: +You can download the ISOs at these addresses: -| System | URL | -| :------------ | :----------------------------------------------------------------- | -| x86 Linux | https://install.determinate.systems/nixos-iso/stable/x86_64-linux | -| aarch64 Linux | https://install.determinate.systems/nixos-iso/stable/aarch64-linux | +| System | URL | +| :------------ | :-------------- | +| x86 Linux | [Download][iso-x86_64] | +| aarch64 Linux | [Download][iso-aarch64] |Add the link references near the other refs at the bottom:
+[iso-x86_64]: https://install.determinate.systems/nixos-iso/stable/x86_64-linux +[iso-aarch64]: https://install.determinate.systems/nixos-iso/stable/aarch64-linuxOptionally add checksum links if available.
lucperkins
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
38-41: Tighten wording, fix pluralization, and standardize punctuation/terminology.Use plural “images,” reference “upstream NixOS,” add periods to list items, and use “wpa_supplicant.”
-> [!NOTE] -> This NixOS installer image is identical to NixOS's ISOs, but with two important differences: -> 1. Flakes are enabled by default via Determinate Nix -> 2. NetworkManager is enabled instead of bare WPA Supplicant. +> [!NOTE] +> These installer images are identical to upstream NixOS ISOs, with two important differences: +> 1. Flakes are enabled by default via Determinate Nix. +> 2. NetworkManager is enabled instead of wpa_supplicant.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
15-15: Bare URL used
(MD034, no-bare-urls)
16-16: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build (UbuntuLatest32Cores128G, x86_64-linux)
- GitHub Check: build (UbuntuLatest32Cores128GArm, aarch64-linux)
🔇 Additional comments (1)
README.md (1)
11-17: Replace bare URLs with reference-style links (fixes MD034)README.md lines 11–17 — Verified both URLs return HTTP 307 (redirect); apply this diff.
-You can download the ISOs at these addresses: +You can download the ISOs at these addresses: -| System | URL | -| :------------ | :----------------------------------------------------------------- | -| x86 Linux | https://install.determinate.systems/nixos-iso/stable/x86_64-linux | -| aarch64 Linux | https://install.determinate.systems/nixos-iso/stable/aarch64-linux | +| System | URL | +| :------------ | :--------------------- | +| x86 Linux | [Stable][iso-x86] | +| aarch64 Linux | [Stable][iso-aarch64] |Add these reference links near the other reference defs:
[iso-x86]: https://install.determinate.systems/nixos-iso/stable/x86_64-linux [iso-aarch64]: https://install.determinate.systems/nixos-iso/stable/aarch64-linux
lucperkins
temporarily deployed
to
production
GitHub Actions
Inactive
Co-authored-by: Cole Helbling <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
README.md (1)
15-15: Prior suggestion addressed.The x86_64 Linux URL matches the earlier reviewer’s suggestion.
🧹 Nitpick comments (2)
README.md (2)
38-41: Soften “identical” claim and tighten wording/punctuation.Avoid overstating parity and standardize periods; prefer “wpa_supplicant.”
> [!NOTE] -> This NixOS installer image is identical to NixOS's ISOs, but with two important differences: -> 1. Flakes are enabled by default via Determinate Nix -> 2. NetworkManager is enabled instead of bare WPA Supplicant. +> This installer image is based on the upstream NixOS ISO, with these differences: +> 1. Flakes are enabled by default via Determinate Nix. +> 2. NetworkManager is enabled instead of wpa_supplicant.
11-17: Replace bare URLs with reference-style links (fixes MD034).Convert the table to Markdown reference links and add the two footnote references.
| System | URL | | :------------ | :----------------------------------------------------------------- | -| x86_64 Linux | https://install.determinate.systems/nixos-iso/stable/x86_64-linux | -| aarch64 Linux | https://install.determinate.systems/nixos-iso/stable/aarch64-linux | +| x86_64 Linux | [stable][iso-x86_64] | +| aarch64 Linux | [stable][iso-aarch64] |Add these references to the link list at the end of the file:
+[iso-x86_64]: https://install.determinate.systems/nixos-iso/stable/x86_64-linux +[iso-aarch64]: https://install.determinate.systems/nixos-iso/stable/aarch64-linuxSanity-check: both endpoints returned HTTP 307 (redirect) — links are reachable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
15-15: Bare URL used
(MD034, no-bare-urls)
16-16: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build (UbuntuLatest32Cores128GArm, aarch64-linux)
- GitHub Check: build (UbuntuLatest32Cores128G, x86_64-linux)
lucperkins
temporarily deployed
to
production
GitHub Actions
Inactive
Summary by CodeRabbit